Remove unnecessary Option from ZalsaLocal::query_stack
#624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #624 will not alter performanceComparing Summary
|
Veykril
commented
Dec 13, 2024
| aqs.iter_mut().for_each(|aq| { | ||
| cycle_query.add_from(aq); | ||
| v.push(aq.database_key_index); | ||
| let (me_recovered, others_recovered, cycle) = local_state.with_query_stack(|from_stack| { |
There was a problem hiding this comment.
The diff here is just the closure wrapping causing an extra level of indentation
Veykril
commented
Dec 13, 2024
| thread_id, | ||
| database_key, | ||
| other_id, | ||
| mem::take(stack), |
There was a problem hiding this comment.
The mem::take is effectively what was Option::take before here
Veykril
force-pushed
the
veykril/push-lrwklvvsooqp
branch
2 times, most recently
from
fc14245 to
ef5c798
Compare
Veykril
force-pushed
the
veykril/push-lrwklvvsooqp
branch
2 times, most recently
from
ea69875 to
1925bf2
Compare
Veykril
force-pushed
the
veykril/push-lrwklvvsooqp
branch
from
1925bf2 to
ac40e4c
Compare
MichaReiser
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a couple panic paths